garydgregory commented on a change in pull request #196:
URL: https://github.com/apache/commons-imaging/pull/196#discussion_r790187859
##########
File path:
src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java
##########
@@ -385,6 +385,10 @@ private BmpImageContents readImageContents(final
InputStream is,
+ bhi.compression);
}
+ if (paletteLength < 0) {
+ throw new ImageReadException("Invalid negative palette length: " +
paletteLength);
Review comment:
Thanks for the clarification. I still think the problem can be detected
a touch earlier and we can give a better exception message. If the * 4
operation would result in a negative number, then the problem is the operand of
that * 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
