Marcono1234 commented on pull request #310: URL: https://github.com/apache/commons-io/pull/310#issuecomment-1022178476
Ok, I have removed the comments now. Here are the issues the TODO comments were about, in case you or someone else wants to have a look at them in the future: - `doGetFullPath(String, boolean)`: In some cases does not call (indirectly) `requireNonNullChars` - `equals(String, String, boolean, IOCase)`: Normalization can throw `IllegalArgumentException` when file names contain null characters. Currently not documented, but not clear what the desired behavior is. Should exception be caught and `false` be returned? If exception should not be caught, then exception has to be documented, also for callers of this method. And should `fileName2` then always be validated as well? Currently if normalization is requested but `fileName1` is `null`, `fileName2` is not checked for null characters. - `getExtension(String)`: Does not call `requireNonNullChars` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
