garydgregory commented on pull request #850: URL: https://github.com/apache/commons-lang/pull/850#issuecomment-1023182605
Hello @SophieHYe and thank you for your interest in Apache Commons Lang ! :-) Without looking too deeply at the specifics of this change I can tell you that this kind of update or fix should be accompanied by a change in Javadoc (if it matters which may not be the case here) and a test that fails without the main change to show what the PR does. Now, specifically, if you cannot cause a test to fail with the current behavior, then you've not fixed anything, so what are you trying to fix? How can the months mismatch when the day of year match? What am I missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
