[
https://issues.apache.org/jira/browse/DBCP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796503#action_12796503
]
Phil Steitz commented on DBCP-317:
----------------------------------
I don't want to make any changes to the collections class (LRUMap), which is OK.
The others are OK - working as designed - as the equals equivalence relation is
defined by equality of underlying jdbc objects. I am OK with vacuos override
to document if that would make findbugs happier and the code easier to
understand, though I am not sure it would make the code easier to understand.
> Findbugs: Class doesn't override equals in superclass
> -----------------------------------------------------
>
> Key: DBCP-317
> URL: https://issues.apache.org/jira/browse/DBCP-317
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
>
> Findbugs: Class doesn't override equals in superclass - 8 instances
> "This class extends a class that defines an equals method and adds fields,
> but doesn't define an equals method itself. Thus, equality on instances of
> this class will ignore the identity of the subclass and the added fields. Be
> sure this is what is intended, and that you don't need to override the equals
> method. Even if you don't need to override the equals method, consider
> overriding it anyway to document the fact that the equals method for the
> subclass just return the result of invoking super.equals(o). "
> Classes (superclass) are:
> cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
> datasources.LRUMap doesn't override SequencedHashMap.equals
> managed.ManagedConnection doesn't override DelegatingConnection.equals
> managed.PoolableManagedConnection doesn't override
> DelegatingConnection.equals
> PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
> PoolableConnection doesn't override DelegatingConnection.equals
> PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
> PoolingConnection doesn't override DelegatingConnection.equals
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
