[
https://issues.apache.org/jira/browse/COMPRESS-612?focusedWorklogId=742921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742921
]
ASF GitHub Bot logged work on COMPRESS-612:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Mar/22 02:21
Start Date: 17/Mar/22 02:21
Worklog Time Spent: 10m
Work Description: andrebrait commented on a change in pull request #254:
URL: https://github.com/apache/commons-compress/pull/254#discussion_r828685900
##########
File path:
src/main/java/org/apache/commons/compress/archivers/tar/TarConstants.java
##########
@@ -227,6 +227,13 @@
*/
byte LF_OLDNORM = 0;
+ /**
+ * Offset inside the header for the "link flag" field.
+ *
+ * @since 1.22
+ */
+ int LF_OFFSET = 156;
Review comment:
I'm just using the same style of the surrounding code. It looks better,
unless I also remove spaces from everything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 742921)
Time Spent: 1h (was: 50m)
> Support atime/ctime and higher time precision for TAR
> -----------------------------------------------------
>
> Key: COMPRESS-612
> URL: https://issues.apache.org/jira/browse/COMPRESS-612
> Project: Commons Compress
> Issue Type: Improvement
> Components: Archivers
> Affects Versions: 1.21
> Reporter: Andre Brait
> Priority: Major
> Labels: tar
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This is a proposal for some code I have already worked on.
> h3. Context
> I'm coding a tool that requires extracting/compressing files. I noticed the
> following shortcomings:
> - -File size is limited to 8GB. This limitation was lifted as of
> POSIX.1-2001 and it also does not exist on GNU and old GNU formats. Bigger
> files are fully supported by some TAR archiving tools such as GNU TAR.
> Reference:
> [https://lists.gnu.org/archive/html/help-tar/2015-04/msg00001.html]-
> -- I think I was actually wrong here in that current implementation should
> support files >8GB if using BIGNUMBER_POSIX.
> - Only modification date is available as a time type.
> - Maximum granularity is seconds, even though the PAX header contains 100ns
> intervals
> - Other time-related PAX headers are considered extra headers (ctime and
> atime)
> My proposal is as follows:
> - Migrate time fields from java.util.Date to java.nio.file.attribute.FileTime
> - Keep backwards compatibility through getter/setter methods and add new
> ones for FileTime
> - Parse times in with a maximal granularity of 100ns intervals from PAX
> headers
> - Read/write ctime and atime and add corresponding fields
> - Write times to PAX headers using a maximum granularity of 100ns intervals
> when in BIGNUMBER_POSIX mode.
> - -Add a new mode BIGNUMBER_POSIX_2001 for writing big numbers, allowing for
> the bigger size, mtime, ctime and atime to be written-
> - -Lift the 8GB limit when using BIGNUMBER_POSIX_2001-
> I already have some code for that in
> https://github.com/andrebrait/commons-compress/tree/COMPRESS-612
> Since compatibility with Android now requires API level 26 and that includes
> FileTime, I think we can do that here as well.
> This will bring tar in line with Zip in this regard.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
