[
https://issues.apache.org/jira/browse/TEXT-211?focusedWorklogId=748873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-748873
]
ASF GitHub Bot logged work on TEXT-211:
---------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/22 20:08
Start Date: 28/Mar/22 20:08
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #281:
URL: https://github.com/apache/commons-text/pull/281#issuecomment-1081088455
This patch cannot be applied manually due to trailing whitespace, please fix:
```
git apply \temp\281.diff
/temp/281.diff:63: trailing whitespace.
/temp/281.diff:64: trailing whitespace.
// following TEXT-211 : the hashcode of the buffer may not be equals
to the hashcode of the TextStringBuilder itself
/temp/281.diff:73: trailing whitespace.
/temp/281.diff:84: trailing whitespace.
assertEquals(hc2b2, hc3b2);
warning: 4 lines add whitespace errors.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 748873)
Time Spent: 5h (was: 4h 50m)
> TextStringBuilder equals method changed behaviour from 1.8 to 1.9
> -----------------------------------------------------------------
>
> Key: TEXT-211
> URL: https://issues.apache.org/jira/browse/TEXT-211
> Project: Commons Text
> Issue Type: Bug
> Affects Versions: 1.9
> Reporter: Nikolaos Georgiou
> Priority: Major
> Time Spent: 5h
> Remaining Estimate: 0h
>
> We found a regression (or breaking compatibility change) in the
> TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9
>
> The 1.8 version (
> [https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915]
> ) would only compare the parts of the buffer that fall within the range
> 0..size.
> The 1.9 version (
> [https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855]
> ) compares the entire buffer arrays.
> If a TextStringBuilder has extra capacity in the buffer, comparison fails.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
