[
https://issues.apache.org/jira/browse/DBCP-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803715#action_12803715
]
Sebb commented on DBCP-323:
---------------------------
I see.
On looking again at the proposed patch, I'm not sure I like it - will comment
on DBCP-8.
> CPDSConnectionFactory fields _password and _username should be final
> --------------------------------------------------------------------
>
> Key: DBCP-323
> URL: https://issues.apache.org/jira/browse/DBCP-323
> Project: Commons Dbcp
> Issue Type: Improvement
> Reporter: Sebb
>
> The fields _password and _username in CPDSConnectionFactory should be final.
> They are set by the ctor, and not changed by the class. Indeed if they are
> changed, it would probably cause problems.
> The containing class is package-protected, so it is clearly not intended to
> be sub-classed by external clients.
> Therefore it should be OK to make the fields final?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
