garydgregory commented on pull request #851: URL: https://github.com/apache/commons-lang/pull/851#issuecomment-1086888746
I've looked at this again and decided that while it would be OK to have this type of change in principle, I want to use the tests as a simple example in this case. I've made adjustments to the Javadoc to reflect this intent. The mocking here is fine (again, in principle) but it makes the code much harder to follow and presents an additional hurdle to people wanting to understand the library. Personally, I prefer to use mocking when it is the only solution for testing or the normal way to test requires too much code. I do not feel this is the case here. Thank you for taking the time to provide this PR though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
