garydgregory commented on code in PR #90:
URL: https://github.com/apache/commons-net/pull/90#discussion_r842755871
##########
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##########
@@ -910,5 +1078,20 @@ protected void sslNegotiation() throws IOException {
}
}
+ /**
+ * Close open sockets.
+ * @param socket main socket for proxy if enabled
+ * @param sslSocket ssl socket
+ * @throws IOException closing sockets is not successful
+ */
+ private void closeSockets(Socket socket, Socket sslSocket) throws
IOException {
Review Comment:
You should have a method that takes a single argument and call it for each
input.
Use final when you can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
