garydgregory commented on PR #143: URL: https://github.com/apache/commons-pool/pull/143#issuecomment-1100735283
The benefit is when you create a factory that throws a checked or unchecked exception, like JDBCException for example, or FooException, then your pooling call sites only need to propagate JDBCException, not java.lang.Exception, which is a horrow show. Furthermore, if your factory throws only unchecked exceptions, your pooling call sites do not have to deal with all APIs throwing Exception. A double win IMO. Gary On Sat, Apr 16, 2022, 14:55 Michael Osipov ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > Honestly, I see zero benefit since there is no specialized *documented* > exception from Pool, but rather from internal code. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-pool/pull/143#pullrequestreview-943879343>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAJB6NYQSNZM732V5HFJ5PTVFMELVANCNFSM5TSV7VQA> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
