[
https://issues.apache.org/jira/browse/COLLECTIONS-802?focusedWorklogId=761470&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761470
]
ASF GitHub Bot logged work on COLLECTIONS-802:
----------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Apr/22 16:32
Start Date: 24/Apr/22 16:32
Worklog Time Spent: 10m
Work Description: samabcde opened a new pull request, #300:
URL: https://github.com/apache/commons-collections/pull/300
…y and currentValue.
- The problem occur when the iterator called `hasNext` and return false,
which set null to `currentKey`. Hence `remove` method calling
`parent.remove(currentKey);` will not remove the current entry.
- Propose to fix by removing lines setting null, other than releasing the
reference earlier, can't think of other reason to set them to null.
- Rename variable to be more understandable.
Issue Time Tracking
-------------------
Worklog Id: (was: 761470)
Remaining Estimate: 0h
Time Spent: 10m
> ReferenceMap iterator remove violates contract
> ----------------------------------------------
>
> Key: COLLECTIONS-802
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-802
> Project: Commons Collections
> Issue Type: Bug
> Components: Map
> Affects Versions: 4.4
> Reporter: Ben Manes
> Priority: Minor
> Attachments: ApacheMapTest.java
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Out of curiosity I ran Guava's testlib Map tests against the Apache types.
> This uncovered a contract bug where {{Iterator.remove()}} is invalidated by
> {{{}hasNext(){}}}, causing its call to no-op due to {{currentKey}} becoming
> {{{}null{}}}. The isolates case is,
> {code:java}
> @Test
> public void iterator_remove() {
> var map = new ReferenceMap<>();
> map.put(1, 2);
> var iter = map.entrySet().iterator();
> assertTrue(iter.hasNext());
> assertTrue(iter.hasNext());
> assertEquals(iter.next(), 1);
> assertFalse(iter.hasNext());
> iter.remove();
> assertEquals(map, Map.of());
> }{code}
> Guava's [testlib|https://github.com/google/guava/tree/master/guava-testlib]
> has good coverage for the Collections Framework and might be worth
> integrating. The simple test case that I wrote is attached.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
