markt-asf commented on code in PR #39:
URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862195635
##########
src/native/windows/src/rprocess.c:
##########
@@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess)
lpProc = APXHANDLE_DATA(hProcess);
CHECK_IF_ACTIVE(lpProc);
+ __apxProcessTerminateChild(lpProc->stProcInfo.dwProcessId, TRUE);
/* Try to close the child's stdin first */
Review Comment:
Can you explain the purpose of the above call? It seems odd to be forcibly
terminating child processes this early. What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
