jfclere commented on code in PR #39:
URL: https://github.com/apache/commons-daemon/pull/39#discussion_r862381173
##########
src/native/windows/src/rprocess.c:
##########
@@ -316,13 +373,16 @@ static BOOL __apxProcessClose(APXHANDLE hProcess)
lpProc = APXHANDLE_DATA(hProcess);
CHECK_IF_ACTIVE(lpProc);
+ __apxProcessTerminateChild(lpProc->stProcInfo.dwProcessId, TRUE);
/* Try to close the child's stdin first */
Review Comment:
Mixing TRUE and FALSE probably...
https://github.com/jfclere/commons-daemon/blob/master/src/native/windows/src/rprocess.c#L413
Here the process MUST be terminated not in line 376.
Good catch I will fix and retest on Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
