[ 
https://issues.apache.org/jira/browse/COLLECTIONS-811?focusedWorklogId=764732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764732
 ]

ASF GitHub Bot logged work on COLLECTIONS-811:
----------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/May/22 06:13
            Start Date: 01/May/22 06:13
    Worklog Time Spent: 10m 
      Work Description: codecov-commenter commented on PR #301:
URL: 
https://github.com/apache/commons-collections/pull/301#issuecomment-1114144824

   # 
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 Report
   > Merging 
[#301](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (919b449) into 
[master](https://codecov.io/gh/apache/commons-collections/commit/1677daceab74895fdf5056c9a48aa94f9e709fb9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 (1677dac) will **increase** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #301      +/-   ##
   ============================================
   + Coverage     85.87%   85.97%   +0.10%     
   - Complexity     4676     4678       +2     
   ============================================
     Files           292      292              
     Lines         13469    13469              
     Branches       1955     1955              
   ============================================
   + Hits          11566    11580      +14     
   + Misses         1326     1321       -5     
   + Partials        577      568       -9     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
 | Coverage Δ | |
   |---|---|---|
   | 
[...he/commons/collections4/map/AbstractHashedMap.java](https://codecov.io/gh/apache/commons-collections/pull/301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdEhhc2hlZE1hcC5qYXZh)
 | `93.82% <0.00%> (+0.98%)` | :arrow_up: |
   | 
[...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh)
 | `91.48% <0.00%> (+1.11%)` | :arrow_up: |
   | 
[...org/apache/commons/collections4/list/TreeList.java](https://codecov.io/gh/apache/commons-collections/pull/301/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L2xpc3QvVHJlZUxpc3QuamF2YQ==)
 | `93.56% <0.00%> (+1.87%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Last update 
[1677dac...919b449](https://codecov.io/gh/apache/commons-collections/pull/301?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
 Read the [comment 
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 764732)
    Time Spent: 2h  (was: 1h 50m)

> Consider integration Guava testlib tests
> ----------------------------------------
>
>                 Key: COLLECTIONS-811
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-811
>             Project: Commons Collections
>          Issue Type: Test
>    Affects Versions: 4.4
>            Reporter: Bruno P. Kinoshita
>            Assignee: Bruno P. Kinoshita
>            Priority: Minor
>             Fix For: 4.5
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> In COLLECTIONS-802 an issue reported was found with the help of Google Guava 
> testlib tests.
> Maybe we could either have something similar (i.e. build ourselves?), use 
> Google Guava's testlib, or find another similar solution. From what I 
> understood, it uses a factory function to create an implementation of a 
> collection interface (e.g. Map) and then runs a series of functional tests 
> over the created object, failing tests if a contract is broken (e.g. 
> iterating a map doesn't leave the next-object as null, as it was the case of 
> the 802 issue).



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to