[
https://issues.apache.org/jira/browse/LANG-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell closed LANG-585.
------------------------------
Resolution: Fixed
Fixed - Exception caught now instead of Throwable. That handles
RuntimeException too.
svn ci -m "Fixing LANG-585. Don't catch Throwable, catch Exception instead. "
Sending
src/main/java/org/apache/commons/lang3/exception/DefaultExceptionContext.java
Transmitting file data .
Committed revision 905922.
> exception.DefaultExceptionContext.getFormattedExceptionMessage catches
> Throwable
> --------------------------------------------------------------------------------
>
> Key: LANG-585
> URL: https://issues.apache.org/jira/browse/LANG-585
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.exception.*
> Reporter: Sebb
> Fix For: 3.0
>
>
> It's generally a bad idea to catch Throwable.
> The getFormattedExceptionMessage method should be changed to catch less; e.g.
> Exception + RuntimeException should be adequate.
> The Javadoc examples in ContextedException and ContextedRuntimeException
> suggest catching Throwable; these examples should be changed too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.