kinow commented on code in PR #181:
URL:
https://github.com/apache/commons-configuration/pull/181#discussion_r873576086
##########
src/main/java/org/apache/commons/configuration2/interpol/ConfigurationInterpolator.java:
##########
@@ -452,4 +511,51 @@ public void setEnableSubstitutionInVariables(final boolean
f) {
public void setParentInterpolator(final ConfigurationInterpolator
parentInterpolator) {
this.parentInterpolator = parentInterpolator;
}
+
+ /** Class encapsulating the default logic to convert resolved variable
values into strings.
+ * This class is thread-safe.
+ */
+ private static final class DefaultStringConverter implements
Function<Object, String> {
+
+ /** Shared instance. */
+ static final DefaultStringConverter INSTANCE = new
DefaultStringConverter();
+
+ /** {@inheritDoc} */
+ @Override
+ public String apply(final Object obj) {
+ return Objects.toString(extractSimpleValue(obj), null);
+ }
+
+ /** Attempt to extract a simple value from {@code obj} for use in
string conversion.
+ * If the input represents a collection of some sort (e.g., an
iterable or array),
+ * the first item from the collection is returned.
+ * @param obj input object
+ * @return extracted simple object
+ */
+ private Object extractSimpleValue(final Object obj) {
+ if (!(obj instanceof String)) {
+ if (obj instanceof Iterable) {
+ return nextOrNull(((Iterable<?>) obj).iterator());
+ } else if (obj instanceof Iterator) {
+ return nextOrNull((Iterator<?>) obj);
+ } else if (obj.getClass().isArray()) {
+ return Array.getLength(obj) > 0
+ ? Array.get(obj, 0)
+ : null;
Review Comment:
I think we have Lang in our list of dependencies. So we could use
`ArrayUtils.get` here if you'd like (but no need to do it if you think it'll
complicate things). I think the call would be like
```
ArrayUtils.get(obj, 0, null)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
