[ 
https://issues.apache.org/jira/browse/CRYPTO-156?focusedWorklogId=772195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772195
 ]

ASF GitHub Bot logged work on CRYPTO-156:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/May/22 00:31
            Start Date: 19/May/22 00:31
    Worklog Time Spent: 10m 
      Work Description: aremily commented on PR #127:
URL: https://github.com/apache/commons-crypto/pull/127#issuecomment-1130828959

   Any committer want to have a look at this?  Seems to me like a code 
improvement.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 772195)
    Time Spent: 2h 40m  (was: 2.5h)

> Common Class Padding, Transform and AlgorithmMode
> -------------------------------------------------
>
>                 Key: CRYPTO-156
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-156
>             Project: Commons Crypto
>          Issue Type: Improvement
>          Components: Cipher
>    Affects Versions: 1.1.0
>            Reporter: Arturo Bernal
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.1.1
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> In order to avoid duplicate code and try to unify the transformation of the 
> token i think it's necessary create the next class/enum:
>  * {{OpenSslTransform}} --> Utility code for dealing with different algorithm 
> types
>  * {{OpenSslPadding}} --> Containg the enumeration of Cipher Algorithm Padding
>  * {{OpenSslAlgorithmMode}} --> Enumeration of Algorithm Mode.
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L208]
>  
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L422]
>  
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/cipher/OpenSsl.java#L47]
>  
> [https://github.com/apache/commons-crypto/blob/master/src/main/java/org/apache/commons/crypto/jna/OpenSslJnaCipher.java#L399]



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to