aherbert commented on PR #114:
URL: https://github.com/apache/commons-rng/pull/114#issuecomment-1138961887

   You have tried to apply this change before in PR #85. Here is what I said 
last time:
   
   "If you look at where this computation is done it is not always required in 
each iteration of the loop. Only step 3 and step 5 require it, and not both at 
the same time. 50% of the time step 2 is executed and you do not require this 
value. It is more efficient to compute it when required. So this change will 
slow down the sampler with 2 unnecessary calls to log functions in the majority 
of cases."
   
   Please be aware that the code path through a random sampler may not be 
obvious. In this case it is better to compute on demand a value that is not 
always used. I will update the code with a comment to avoid this change attempt 
repeating in the future.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to