[ 
https://issues.apache.org/jira/browse/MATH-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542959#comment-17542959
 ] 

Elia Bertolina commented on MATH-1647:
--------------------------------------

Thank you for your feedback.

I bumped into this bug while using HaltonSequenceGenerator as a benchmark in 
the context of my bachelor thesis on automatic test case generation, and I 
thought it was useful to report it.

However I am not using this library in a specific software project at the 
moment, and thus I am not able to provide a patch or an evaluation of the 
actual impact.

 

> HaltonSequenceGenerator.skipTo() not throwing proper NotPositiveException
> -------------------------------------------------------------------------
>
>                 Key: MATH-1647
>                 URL: https://issues.apache.org/jira/browse/MATH-1647
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.6.1
>            Reporter: Elia Bertolina
>            Priority: Major
>             Fix For: 4.0
>
>
> HaltonSequenceGenerator.skipTo(int index) does not throw a 
> NotPositiveException when the parameter is negative.In the documentation it 
> is stated that an NotPositiveException will be thrown if the parameter value 
> is less than zero.
> However, in this test case:
> {code:java}
> public class HaltonSequenceGenerator_Test{
>     public void test() throws Throwable{
>         HaltonSequenceGenerator haltonSequenceGenerator = new 
>         HaltonSequenceGenerator(1);
>         try {
>             double[] doubleArray =
>             haltonSequenceGenerator.skipTo((-4584));
>             org.junit.Assert.fail();
>         } catch 
>         (org.apache.commons.math3.exception.NotPositiveException e){
>         //NotPositiveException caught and test successful        
>         }    
>     }
> } {code}
> The int parameter is negative and a NotPositiveException should be thrown, 
> however the method executes normally, and test case fails.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to