garydgregory commented on code in PR #125:
URL: https://github.com/apache/commons-text/pull/125#discussion_r889350288


##########
src/main/java/org/apache/commons/text/RandomStringGenerator.java:
##########
@@ -247,6 +247,7 @@ public String generate(final int minLengthInclusive, final 
int maxLengthInclusiv
      * Some commonly used predicates are provided by the {@link 
CharacterPredicates} enum.</p>
      *
      * <p>This class is not thread safe.</p>
+     *

Review Comment:
   No need for extra whitespace here.



##########
src/main/java/org/apache/commons/text/RandomStringGenerator.java:
##########
@@ -328,7 +329,7 @@ public Builder withinRange(final int minimumCodePoint, 
final int maximumCodePoin
          * Specifies the array of minimum and maximum char allowed in the
          * generated string.
          * </p>
-         *
+         * <p>
          * For example:
          * <pre>

Review Comment:
   If you open a p tag above, then close it before this pre tag.



##########
src/main/java/org/apache/commons/text/RandomStringGenerator.java:
##########
@@ -455,12 +446,15 @@ public Builder selectFrom(final char... chars) {
 
         /**
          * <p>Builds the {@code RandomStringGenerator} using the properties 
specified.</p>
+         *
          * @return The configured {@code RandomStringGenerator}
          */
         @Override
         public RandomStringGenerator build() {
             return new RandomStringGenerator(minimumCodePoint, 
maximumCodePoint, inclusivePredicates,
                     random, characterList);
         }
+

Review Comment:
   Don't add whitespace here.



##########
src/main/java/org/apache/commons/text/RandomStringGenerator.java:
##########
@@ -455,12 +446,15 @@ public Builder selectFrom(final char... chars) {
 
         /**
          * <p>Builds the {@code RandomStringGenerator} using the properties 
specified.</p>
+         *
          * @return The configured {@code RandomStringGenerator}
          */
         @Override
         public RandomStringGenerator build() {
             return new RandomStringGenerator(minimumCodePoint, 
maximumCodePoint, inclusivePredicates,
                     random, characterList);
         }
+
     }
+

Review Comment:
   Don't add whitespace here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to