[
https://issues.apache.org/jira/browse/LANG-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830653#action_12830653
]
Henri Yandell edited comment on LANG-588 at 2/7/10 5:23 AM:
------------------------------------------------------------
It was for IP sake - I wrote it as an exercise instead of for any use. Happy to
use yours instead.
Comments on your patches:
* Javadoc for pairOf/matchedPairOf needs filling in.
* @since should be '3.0' and not 'Lang 3.0'
* The static import in the tests makes me cringe, but I know you like using
them. First time I looked at the code (as I looked at tests first) I went
looking in the file to see where the utility pairOf method was, while wondering
why you'd done such a thing.
* I'm not sure about the Iterable concept for MatchedPair. It could be in the
parent as well as an Object iteration.
* I do like the notion of Iterable if it becomes a tree walker - i.e. it
iterates down Pairs of Pairs. It could be: depthFirstIterate() &
breadthFirstIterate().
* Possibly some kind of construction parameter that sets the default to be
depthFirst or breadthFirst. Or we could just declare one to be the default.
was (Author: bayard):
It was for IP sake - I wrote it as an exercise instead of for any use.
Happy to use yours instead.
Comments on your patches:
* Javadoc for pairOf/matchedPairOf needs filling in.
* @since should be '3.0' and not 'Lang 3.0'
* The static import in the tests makes me cringe, but I know you like using
them. First time I looked at the code (as I looked at tests first) I went
looking in the file to see where the utility pairOf method was, while wondering
why you'd done such a thing.
* I'm not sure about the Iterable concept for MatchedPair.
* I do like the notion of Iterable if it becomes a tree walker - i.e. it
iterates down Pairs of Pairs. It could then be in the parent and could be:
depthFirstIterate() & breadthFirstIterate().
> Create a basic Pair<L, R> class
> -------------------------------
>
> Key: LANG-588
> URL: https://issues.apache.org/jira/browse/LANG-588
> Project: Commons Lang
> Issue Type: New Feature
> Components: lang.*
> Reporter: Matt Benson
> Fix For: 3.0
>
> Attachments: MatchedPair.java, MatchedPairTest.java, Pair.java,
> PairTest.java
>
>
> [lang] is the perfect place to provide a basic typed Pair class. I have
> written such a class for my employer (who hasn't?) but can/will rewrite blind
> to avoid IP issues. I think it's also nice to go ahead and extend this to
> MatchedPair<T> extends Pair<T, T> as well.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
