Claude Warren created COLLECTIONS-819:
-----------------------------------------
Summary: BloomFilter: Remove IndexProducer.fromArray()
Key: COLLECTIONS-819
URL: https://issues.apache.org/jira/browse/COLLECTIONS-819
Project: Commons Collections
Issue Type: Improvement
Components: Collection
Affects Versions: 4.5
Reporter: Claude Warren
h3.
!https://avatars.githubusercontent.com/u/886334?s=48&v=4|width=24,height=24!
*[aherbert|https://github.com/aherbert]* [on 27
Feb|https://github.com/apache/commons-collections/pull/258#discussion_r813449970]
This method is only used in testing. What is the use case? Note that
BloomFilter interface cannot merge an IndexProducer. This functionality is only
provided by the constructors for SimpleBloomFilter and SparseBloomFitler. The
method is trivially implemented if a user did want to populate a Bloom filter
with certain indices. But I do not see why they would unless deserialising its
stored representation. Given that we are not supporting any such constructors
for the ArrayCountingBloomFilter (creating and populating at the same time)
this seems like a partial support in the library. Either the serialisation and
deserialisation is better supported, or we drop these methods from the public
API for now.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
