shalk commented on PR #912:
URL: https://github.com/apache/commons-lang/pull/912#issuecomment-1154103934

   > 
   
   I found some apis return null if argument is null  and the other apis check 
them throw npe.  they are different behave for argument.  
   For example, `ClassUtils.getAllInterfaces` document ` {@code null} if null 
input` , so i think append `ClassUtils.getClass` with   `@throws 
NullPointerException if the className is null` is  meaningful. 
   
   I aslo found  ClassUtilsTest have cover the npe case. So document can also 
cover it  and these document will not break code.
   
   May be we should check which kind of  npe should declare in document.
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to