[ 
https://issues.apache.org/jira/browse/BCEL-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Kriegisch updated BCEL-362:
-------------------------------------
    Description: 
_Disclaimer: I am not a byte code buff, so if I am misunderstanding anything 
here, please apologise for raising a stupid issue, try to be patient and 
explain it to me._

When looking at the class 
{{[ConstantPool|https://github.com/apache/commons-bcel/blob/5165671d2bc4bed17918051f1689ee5fd4c3425a/src/main/java/org/apache/bcel/classfile/ConstantPool.java]}},
 it seems as if condy is not being handled in methods
* {{constantToString(Constant)}},
* {{addConstant(Constant, ConstantPool)}},
* {{addConstantDynamic(int, int)}} (method does not exist, not sure if it would 
be necessary).

I would have expected something like {{case Constants.CONSTANT_Dynamic}} with 
proper handling for this case in the first two methods. 

When using BCEL in order to parse class files using condy, like JaCoCo creates 
them, this causes errors. FYI, we are using BCEL code in AspectJ, and whenever 
people combine it with JaCoCo, corresponding problems occur.

  was:
When looking at the class 
{{[ConstantPool|https://github.com/apache/commons-bcel/blob/5165671d2bc4bed17918051f1689ee5fd4c3425a/src/main/java/org/apache/bcel/classfile/ConstantPool.java]}},
 it seems as if condy is not being handled in methods
* {{constantToString(Constant)}},
* {{addConstant(Constant, ConstantPool)}},
* {{addConstantDynamic(int, int)}} (method does not exist, not sure if it would 
be necessary).

I would have expected something like {{case Constants.CONSTANT_Dynamic}} with 
proper handling for this case in the first two methods. 

When using BCEL in order to parse class files using condy, like JaCoCo creates 
them, this causes errors. FYI, we are using BCEL code in AspectJ, and whenever 
people combine it with JaCoCo, corresponding problems occur.


> Handling for Constants.CONSTANT_Dynamic is missing in class ConstantPool
> ------------------------------------------------------------------------
>
>                 Key: BCEL-362
>                 URL: https://issues.apache.org/jira/browse/BCEL-362
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Alexander Kriegisch
>            Priority: Major
>
> _Disclaimer: I am not a byte code buff, so if I am misunderstanding anything 
> here, please apologise for raising a stupid issue, try to be patient and 
> explain it to me._
> When looking at the class 
> {{[ConstantPool|https://github.com/apache/commons-bcel/blob/5165671d2bc4bed17918051f1689ee5fd4c3425a/src/main/java/org/apache/bcel/classfile/ConstantPool.java]}},
>  it seems as if condy is not being handled in methods
> * {{constantToString(Constant)}},
> * {{addConstant(Constant, ConstantPool)}},
> * {{addConstantDynamic(int, int)}} (method does not exist, not sure if it 
> would be necessary).
> I would have expected something like {{case Constants.CONSTANT_Dynamic}} with 
> proper handling for this case in the first two methods. 
> When using BCEL in order to parse class files using condy, like JaCoCo 
> creates them, this causes errors. FYI, we are using BCEL code in AspectJ, and 
> whenever people combine it with JaCoCo, corresponding problems occur.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to