[ 
https://issues.apache.org/jira/browse/NUMBERS-188?focusedWorklogId=785183&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-785183
 ]

ASF GitHub Bot logged work on NUMBERS-188:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jun/22 17:08
            Start Date: 27/Jun/22 17:08
    Worklog Time Spent: 10m 
      Work Description: aherbert commented on PR #113:
URL: https://github.com/apache/commons-numbers/pull/113#issuecomment-1167625512

   You should add a suppression to:
   ```
   src/main/resources/checkstyle/checkstyle-suppressions.xml
   ```
   There is already this suppression for Complex:
   ```
   <suppress checks="FileLengthCheck" files=".*[/\\]Complex(Test)?\.java" />
   ```
   You may be able to drop the suppression for Complex if it is now under 2000 
lines and change it to your other files.
   
   If you rebase on the branch again (because I have now updated the 
notifications for GH actions to send e-mails upon failure) and I can then 
approve your PR to allow it to run the GH workflows.
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 785183)
    Time Spent: 1h 50m  (was: 1h 40m)

> Static Method Refactor and Functional Interfaces
> ------------------------------------------------
>
>                 Key: NUMBERS-188
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-188
>             Project: Commons Numbers
>          Issue Type: Sub-task
>            Reporter: Sumanth Sulur Rajkumar
>            Priority: Minor
>              Labels: gsoc2022
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Refactored existing instance methods in Complex class as static functions in 
> ComplexFunctions class using functional interface signatures



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to