aherbert commented on PR #317:
URL: 
https://github.com/apache/commons-collections/pull/317#issuecomment-1169737462

   I believe my original idea was to move the entire `IndexFilter` class out of 
the `Hasher` interface. The public API should be:
   
   ```Java
   public final class IndexFilter {
       /** No instances. */
       private IndexFilter() {}
   
       // ...
       public static IntPredicate create(Shape shape, IntPredicate consumer);
   }
   ```
   
   Then the workings of the returned predicate can be hidden. The two classes 
`ArrayTracker` and `BitMapTracker` should be inner classes and private (or 
package-private for testing). The implementations can be updated in the future 
without any change to the public API.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to