arturobernalg commented on code in PR #136:
URL: https://github.com/apache/commons-codec/pull/136#discussion_r912395548
##########
src/main/java/org/apache/commons/codec/language/DaitchMokotoffSoundex.java:
##########
@@ -494,9 +494,6 @@ private String[] soundex(final String source, final boolean
branching) {
for (final Rule rule : rules) {
if (rule.matches(inputContext)) {
- if (branching) {
- nextBranches.clear();
- }
Review Comment:
'nextBranches' is always empty collections. The loop will be exit in the
line 525 with the `break` in the first iterations or/and when the rule match `
if (rule.matches(inputContext))`. So, at the end its always empty and its
redundant.
If we remove the break of the line, that is a whole new history :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]