darkma773r commented on code in PR #117: URL: https://github.com/apache/commons-numbers/pull/117#discussion_r922852640
########## commons-numbers-complex/src/main/java/org/apache/commons/numbers/complex/ComplexConstructor.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.commons.numbers.complex; + +/** + * Define a constructor for a Complex. + * @param <R> Generic + */ +@FunctionalInterface +public interface ComplexConstructor<R> { Review Comment: What do you think of using the name pair "source"/"sink". I could then picture the following: ```java // interface for obtaining complex values public interface ComplexSource { double getReal(); double getImaginary(); default real() { return getReal(); } default imag() { return getImaginary(); } } // interface for accepting complex values, optionally returning a result @FunctionalInterface public interface ComplexSink<R> { R accept(double real, double imaginary); } ``` These interfaces could then be used as follows: ```java // existing Complex class public final class Complex implements ComplexSource { // ... } // TBD complex value container class public class ComplexBuffer implements ComplexSource, ComplexSink<ComplexBuffer> { // indexing methods similar to java.nio.Buffer public int position(); public ComplexBuffer position(int pos); // get the values at the current position public double getReal() { ... } public double getImaginary() { ... } // set the values at the current position ComplexBuffer accept(double real, double imaginary) { // ... return this; } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
