[
https://issues.apache.org/jira/browse/COLLECTIONS-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claude Warren resolved COLLECTIONS-829.
---------------------------------------
Resolution: Done
replace old
{code:java}
BloomFilter bf = bf1.merge(x){code}
with
{noformat}
BloomFilter bf = bf1.copy();
br.merge( x );
{noformat}
> BloomFilter: Drop mergeInPlace
> ------------------------------
>
> Key: COLLECTIONS-829
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-829
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection
> Reporter: Claude Warren
> Assignee: Claude Warren
> Priority: Major
> Labels: bloom-filter
> Fix For: 4.5
>
>
> It is confusing with merge being present as well. A user can always copy a
> filter and do a merge to a new copy. Currently the merge to a copy has a
> return statement of the mergeInPlace that is being ignored. So you may return
> a copy that has not been correctly merged. This is not possible with the
> current implementations except the ArrayCountingBloomFilter which can return
> false if the state is invalid after merge.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
