garydgregory commented on code in PR #280:
URL: https://github.com/apache/commons-vfs/pull/280#discussion_r932140182
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/sftp/SftpFileSystem.java:
##########
@@ -260,21 +261,33 @@ public int[] getGroupsIds() throws JSchException,
IOException {
throw new JSchException(
"Could not get the groups id of the current
user (error code: " + code + ")");
}
- // Retrieve the different groups
- final String[] groups =
output.toString().trim().split("\\s+");
-
- final int[] groupsIds = new int[groups.length];
- for (int i = 0; i < groups.length; i++) {
- groupsIds[i] = Integer.parseInt(groups[i]);
- }
- this.groupsIds = groupsIds;
+ this.groupsIds = parseGroupIdOutput(output);
}
}
}
return groupsIds;
}
+ /**
+ * Parses the output of the 'id -G' command
+ *
+ * @param output The output from the command
+ * @return the (numeric) group IDs.
+ * @since 2.10
Review Comment:
You only need `since` tags in new public and protected elements because this
is what a user can access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
