[ 
https://issues.apache.org/jira/browse/BCEL-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576788#comment-17576788
 ] 

Alexander Kriegisch edited comment on BCEL-362 at 8/8/22 2:00 PM:
------------------------------------------------------------------

Sorry if I am asking a naive question, but not knowing anything about the BCEL 
project team, I would like to know if you are the only active commiter or if 
there are others who are both byte code buffs (which you say you are not) and 
might have time to look into this issue. As an AspectJ committer, my FOSS time 
is also very limited. In my daytime job, I am not even a developer but an agile 
coach. My last money I made with coding ~20 years ago.

The issue I am raising here is not about some kind of minor bug, but rather 
about a very basic feature of the JVM which was introduced in Java 11 (released 
in September 2018) and which BCEL does not seem to fully support to this date. 
I was and am trying to support you by pre-qualifying this issue on your behalf 
as best I can with my very limited knowledge, but I think that an active BCEL 
maintainer should find the root cause and be able to fix it with a very small 
investment of time.


was (Author: kriegaex):
Sorry if I am asking a naive question, but not knowing anything about the BCEL 
project team, I would like to know if you are the only active commiter or if 
there are others who are both byte code buffs (which you say you are not) and 
might have time to look into this issue. As an AspectJ committer, my FOSS time 
is also very limited. In my daytime job, I am not even a developer but an agile 
coach. My last money I made with coding ~20 years ago.

The issue I am raising here is not about some kind of minor bug, but rather 
about a very basic feature of the JVM which was introduced in Java 11 (released 
in September 2018) and which BCEL does not seem to fully support to this date. 
I was and am trying my very best to support you by pre-qualifying this issue on 
your behalf as best I can with my very limited knowledge, but I think that an 
active BCEL maintainer should find the root cause and be able to fix it with a 
very small investment of time.

> Handling for Constants.CONSTANT_Dynamic is missing in class ConstantPool
> ------------------------------------------------------------------------
>
>                 Key: BCEL-362
>                 URL: https://issues.apache.org/jira/browse/BCEL-362
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Alexander Kriegisch
>            Priority: Major
>
> _Disclaimer: I am not a byte code buff, so if I am misunderstanding anything 
> here, please forgive me for raising a stupid issue, try to be patient and 
> explain it to me._
> When looking at the class 
> {{[ConstantPool|https://github.com/apache/commons-bcel/blob/5165671d2bc4bed17918051f1689ee5fd4c3425a/src/main/java/org/apache/bcel/classfile/ConstantPool.java]}},
>  it seems as if condy is not being handled in methods
> * {{constantToString(Constant)}},
> * {{addConstant(Constant, ConstantPool)}},
> * {{addConstantDynamic(int, int)}} (method does not exist, not sure if it 
> would be necessary).
> I would have expected something like {{case Constants.CONSTANT_Dynamic}} with 
> proper handling for this case in the first two methods. 
> When using BCEL in order to parse class files using condy, like JaCoCo 
> creates them, this causes errors. FYI, we are using BCEL code in AspectJ, and 
> whenever people combine it with JaCoCo, corresponding problems occur.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to