[
https://issues.apache.org/jira/browse/IO-473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17576890#comment-17576890
]
Amir Gur edited comment on IO-473 at 8/8/22 4:58 PM:
-----------------------------------------------------
[~ggregory], thanks for the note.
* My additions were all searches on classpath when calling
[clazz.getResource(...) on the
PR|https://github.com/apache/commons-io/pull/7/commits/f613c4c6a22dabd427564954e8be60c6dc48764f#diff-0bd8160a11e12ea1f96476a00e78d0a95b965d07c7fe126e1af498c08511dd70R516],
while the methods you listed are all passing a base directory to start the
search from.
* Would be nice to merge all {{FileUtils.listFiles(...)}} methods where they
all allow either a root-dir or a classpath based search.
* May want to consider if these utils belong on FileUtils, or another one such
as [Class|Path]Utils. Or maybe already exist elsewhere.
* Can/should we re-open this ticket? (Possibly this is still needed, even if
newer progress elsewhere covered it (ex. new core-java, kotlin, etc), since
apache-commons always independently supported older versions of java which are
still widely used)
was (Author: agur):
[~ggregory], thanks for the note.
* My additions were all searches on classpath when calling
[clazz.getResource(...) on the
PR|https://github.com/apache/commons-io/pull/7/commits/f613c4c6a22dabd427564954e8be60c6dc48764f#diff-0bd8160a11e12ea1f96476a00e78d0a95b965d07c7fe126e1af498c08511dd70R516],
while the methods you listed are all passing a base directory to start the
search from.
* Would be nice to merge all {{FileUtils.listFiles(...)}} methods where they
all allow either a root-dir or a classpath based search.
* Can/should we re-open this ticket? (Possibly this is still needed, even if
newer progress elsewhere covered it (ex. new core-java, kotlin, etc), since
apache-commons always independently supported older versions of java which are
still widely used)
> Add convenient listFiles to FileUtils
> -------------------------------------
>
> Key: IO-473
> URL: https://issues.apache.org/jira/browse/IO-473
> Project: Commons IO
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 2.4
> Reporter: Amir Gur
> Priority: Trivial
>
> Lacking a few convenience methods such as:
> {code}
> - Collection<File> listFiles(String[] extensions)
> - Collection<File> listFiles(String extension, String classpathRoot)
> {code}
> Created [pull request 7|https://github.com/apache/commons-io/pull/7].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
