[
https://issues.apache.org/jira/browse/COMPRESS-623?focusedWorklogId=800225&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800225
]
ASF GitHub Bot logged work on COMPRESS-623:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/22 08:54
Start Date: 12/Aug/22 08:54
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #306:
URL: https://github.com/apache/commons-compress/pull/306#issuecomment-1212884617
#
[Codecov](https://codecov.io/gh/apache/commons-compress/pull/306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#306](https://codecov.io/gh/apache/commons-compress/pull/306?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(3c6b0b0) into
[master](https://codecov.io/gh/apache/commons-compress/commit/7cae698b1b593de908722b5089cf8506a9e67057?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7cae698) will **decrease** coverage by `0.03%`.
> The diff coverage is `53.12%`.
```diff
@@ Coverage Diff @@
## master #306 +/- ##
============================================
- Coverage 80.05% 80.01% -0.04%
+ Complexity 6621 6620 -1
============================================
Files 339 339
Lines 25416 25420 +4
Branches 4199 4200 +1
============================================
- Hits 20346 20341 -5
- Misses 3473 3480 +7
- Partials 1597 1599 +2
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-compress/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...apache/commons/compress/archivers/zip/ZipFile.java](https://codecov.io/gh/apache/commons-compress/pull/306/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29tcHJlc3MvYXJjaGl2ZXJzL3ppcC9aaXBGaWxlLmphdmE=)
| `77.00% <53.12%> (-1.77%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 800225)
Time Spent: 20m (was: 10m)
> Speed up ZipFile's raw stream copying by not seeking for local headers until
> they're needed
> -------------------------------------------------------------------------------------------
>
> Key: COMPRESS-623
> URL: https://issues.apache.org/jira/browse/COMPRESS-623
> Project: Commons Compress
> Issue Type: Improvement
> Reporter: Dawid Weiss
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I have a somewhat odd use case with gigabytes of ZIP files, each with
> thousands of documents (on comparatively slow, network drives). We need to
> restructure these ZIPs without the need to recompress files.
> The above turns out to work almost perfectly with raw-data copying ZipFile
> offers but empirical tests showed a major slowdown in the initial opening of
> zip files, linked to multiple reads/seeks for local file headers. If an
> option is passed to ignore those headers, raw streams are inaccessible.
> I've taken a look at the code and the code in getRawInputStream could
> basically do the same thing that getInputStream does - lazily load the
> missing offset via getDataOffset(ZipEntry). In fact, getInputStream could
> just call getRawInputStream directly, which avoids some code duplication.
> I also restructured the code that maintains LinkedList for duplicated names a
> bit. I think this bit could be removed altogether and replaced with a
> pointer-chain list directly on Entry class instances (the map would then
> point at the first entry; duplicated entries are an oddity and infrequent in
> the wild).
> I see speedups for opening and copying random raw streams in the order of
> 3-4x and all the current tests pass. I filed a PR at github - happy to
> discuss it there.
> https://github.com/apache/commons-compress/pull/306
--
This message was sent by Atlassian Jira
(v8.20.10#820010)