[ 
https://issues.apache.org/jira/browse/CSV-301?focusedWorklogId=800510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-800510
 ]

ASF GitHub Bot logged work on CSV-301:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Aug/22 08:02
            Start Date: 15/Aug/22 08:02
    Worklog Time Spent: 10m 
      Work Description: sman-81 commented on PR #250:
URL: https://github.com/apache/commons-csv/pull/250#issuecomment-1214729080

   @kinow, @garydgregory
   
   Thanks for your good thoughts.
   
   > Don't forget that a major release entails a package name and artifact name 
change, [..]
   
   ```
   org.apache.commons:commons-csv2 package org.apache.commons.csv2
   org.apache.commons:commons-csv3 package org.apache.commons.csv3
   ```
   
   omg ... are you forced to do in this way by some set of conventions?
   
   I personally prefer semver and that changes to the major version are 
entitled to break binary compatibility.
   
   I don't know of anyone personally who replaces jars in a system without 
recompiling. I understand there is value in being able to do so (e.g. security 
patches). Does commons-csv or other Apache libraries publish and advertise this 
fact? It's kind of a unique feature, that comes at a price. If users don't know 
about the guaranteed binary compatibility, they would always recompile. I 
personally always recompile (working mostly on internal systems), as I would 
not want to take the risk of crashing with NoSuchMethodError at at run-time.
   
   The deprecation warnings will be addressed while removing old API and old 
tests in a new major release.
   We can close my PR - no problem at all. The work is easily recreated when 
releasing.
   
   Again, thanks for your thoughts and feedback - have a great week.
   




Issue Time Tracking
-------------------

    Worklog Id:     (was: 800510)
    Time Spent: 1h 40m  (was: 1.5h)

> Fix deprecation warnings in unit tests
> --------------------------------------
>
>                 Key: CSV-301
>                 URL: https://issues.apache.org/jira/browse/CSV-301
>             Project: Commons CSV
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Markus Spann
>            Priority: Trivial
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Fix deprecation warnings in unit tests of the project.
> The project has a large number of deprecation warnings in unit tests. Use 
> updated API in these tests.
> Tests should keep up-to-date with the API, they often serve as a blueprint 
> for how to use functionality.
> I will provide a pull request shortly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to