Claudenw commented on code in PR #329:
URL:
https://github.com/apache/commons-collections/pull/329#discussion_r946468361
##########
src/main/java/org/apache/commons/collections4/bloomfilter/SimpleBloomFilter.java:
##########
@@ -194,7 +194,7 @@ public boolean merge(Hasher hasher) {
@Override
public boolean merge(BloomFilter other) {
Objects.requireNonNull(other, "other");
- if (other.isSparse()) {
+ if ((other.characteristics()&SPARSE)>0) {
Review Comment:
fixed
##########
src/main/java/org/apache/commons/collections4/bloomfilter/SparseBloomFilter.java:
##########
@@ -58,7 +58,7 @@ public SparseBloomFilter(BloomFilter other) {
Objects.requireNonNull(other, "other");
this.shape = other.getShape();
this.indices = new TreeSet<>();
- if (other.isSparse()) {
+ if ((other.characteristics()&SPARSE)>0) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
