[
https://issues.apache.org/jira/browse/LANG-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583078#comment-17583078
]
Alex Herbert commented on LANG-1603:
------------------------------------
The method getProperWhole is covered by intValue. The Fraction class in lang
has both methods with duplicate logic.
So the only method to add any logic would be getProperNumerator.
These methods would have to be replicated in the BigFraction class too where
they would return BigInteger results.
> Deprecate the "Fraction" class
> ------------------------------
>
> Key: LANG-1603
> URL: https://issues.apache.org/jira/browse/LANG-1603
> Project: Commons Lang
> Issue Type: Sub-task
> Reporter: Gilles Sadowski
> Priority: Major
> Fix For: 4.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [Fraction|https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob;f=src/main/java/org/apache/commons/lang3/math/Fraction.java;h=e90e340ac5578126492471841f4a97548dbb49f7;hb=HEAD]
> in [Lang] vs
> [Fraction|https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java;h=f1bc54278a9a65538638ddbe9d17a28452a60ca4;hb=HEAD]
> in [Numbers].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
