[
https://issues.apache.org/jira/browse/LANG-1603?focusedWorklogId=802591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802591
]
ASF GitHub Bot logged work on LANG-1603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/22 18:45
Start Date: 22/Aug/22 18:45
Worklog Time Spent: 10m
Work Description: garydgregory commented on code in PR #935:
URL: https://github.com/apache/commons-lang/pull/935#discussion_r951787970
##########
src/main/java/org/apache/commons/lang3/math/Fraction.java:
##########
@@ -31,7 +31,8 @@
* based and thus suffers from various overflow issues. For a BigInteger based
* equivalent, please see the Commons Math BigFraction class. </p>
*
- * @deprecated for fraction implementation from commons-numbers
+ * @deprecated for <a
href="https://commons.apache.org/proper/commons-math/javadocs/api-3.6.1/index.html";>Fraction</a>
+ * from commons-numbers
Review Comment:
Still not quite right: You talk about Commons Numbers but link to Commons
Math as a whole. You want the URL to the Commons Numbers Fraction package or
class.
Issue Time Tracking
-------------------
Worklog Id: (was: 802591)
Time Spent: 1h (was: 50m)
> Deprecate the "Fraction" class
> ------------------------------
>
> Key: LANG-1603
> URL: https://issues.apache.org/jira/browse/LANG-1603
> Project: Commons Lang
> Issue Type: Sub-task
> Reporter: Gilles Sadowski
> Priority: Major
> Fix For: 4.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> [Fraction|https://gitbox.apache.org/repos/asf?p=commons-lang.git;a=blob;f=src/main/java/org/apache/commons/lang3/math/Fraction.java;h=e90e340ac5578126492471841f4a97548dbb49f7;hb=HEAD]
> in [Lang] vs
> [Fraction|https://gitbox.apache.org/repos/asf?p=commons-numbers.git;a=blob;f=commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/Fraction.java;h=f1bc54278a9a65538638ddbe9d17a28452a60ca4;hb=HEAD]
> in [Numbers].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
