[GitHub] [commons-io] ArdenL-Liu commented on a diff in pull request #374: IOUtils.byteArray(int size) add the verification to assure that the size is legal(size > 0), the illegal(size <=0) should throw IllegalArgumentException.

Thu, 25 Aug 2022 20:38:49 -0700 


ArdenL-Liu commented on code in PR #374:
URL: https://github.com/apache/commons-io/pull/374#discussion_r955621214


##########
src/test/java/org/apache/commons/io/IOUtilsTest.java:
##########
@@ -1716,4 +1716,18 @@ public void testWriteLittleString() throws IOException {
         }
     }
 
+    @Test
+    public void testByteArrayWithIllegalSize() {
+        try {
+            int size = -1;
+            byte[] bytes = IOUtils.byteArray(size);
+
+            size = 0;
+            bytes = IOUtils.byteArray(size);
+        }catch (Exception e) {
+            assertEquals(e.getClass().getName(), 
IllegalArgumentException.class.getName());
+        }

Review Comment:
   Hi garydgregory,
       Thank you for your good suggestion, I updated the doc and changed the 
unittest, you can review it again.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to