[GitHub] [commons-io] garydgregory commented on a diff in pull request #374: IOUtils.byteArray(int size) add the verification to assure that the size is legal(size > 0), the illegal(size <=0) should throw IllegalArgumentException.

Sat, 27 Aug 2022 07:51:45 -0700 


garydgregory commented on code in PR #374:
URL: https://github.com/apache/commons-io/pull/374#discussion_r956590623


##########
src/main/java/org/apache/commons/io/IOUtils.java:
##########
@@ -346,6 +346,7 @@ public static byte[] byteArray() {
      *
      * @param size array size.
      * @return a new byte array of the given size.
+     * @throws NegativeArraySizeException if the size is negative.

Review Comment:
   This PR seems ok to me now except for this addition. We do not document this 
type of JVM exception anywhere else IIRC. If we were to doc this, then it would 
make sense to doc all callers as well, then this would touch almost everything 
which would not help anyone IMO.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to