Claudenw commented on code in PR #331:
URL:
https://github.com/apache/commons-collections/pull/331#discussion_r958610813
##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractBloomFilterTest.java:
##########
@@ -316,20 +345,20 @@ public final void testMerge() {
assertThrows(IllegalArgumentException.class, () -> bf1.merge(new
BadHasher(-1)));
// test error when bloom filter returns values out of range
- final BloomFilter bf5 = new SimpleBloomFilter(
- Shape.fromKM(getTestShape().getNumberOfHashFunctions(), 3 *
Long.SIZE),
- new IncrementingHasher(Long.SIZE * 2, 1));
+ BloomFilter bf5 = new SimpleBloomFilter(
+ Shape.fromKM(getTestShape().getNumberOfHashFunctions(), 3 *
Long.SIZE));
+ bf5.merge(new IncrementingHasher(Long.SIZE * 2, 1));
assertThrows(IllegalArgumentException.class, () -> bf1.merge(bf5));
- final BloomFilter bf6 = new SparseBloomFilter(
- Shape.fromKM(getTestShape().getNumberOfHashFunctions(), 3 *
Long.SIZE),
- new IncrementingHasher(Long.SIZE * 2, 1));
+ BloomFilter bf6 = new SparseBloomFilter(
+ Shape.fromKM(getTestShape().getNumberOfHashFunctions(), 3 *
Long.SIZE));
+ bf6.merge(new IncrementingHasher(Long.SIZE * 2, 1));
assertThrows(IllegalArgumentException.class, () -> bf1.merge(bf6));
}
- private static void assertIndexProducerConstructor(Shape shape, int[]
values, int[] expected) {
+ private void assertIndexProducerConstructor(Shape shape, int[] values,
int[] expected) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
