kinow commented on PR #377:
URL: https://github.com/apache/commons-io/pull/377#issuecomment-1236816687

   >Notice that in the (old) Jira tickets above, two are about attributes not 
being copied, which we now do but this PR proposes to undo. So catch-22. Ideas?
   
   I think we should start by reverting the change from 2.9 with this PR, and 
prepare a new release. I was only suggesting that someone looks at the other 
JIRA issues to close if it is fixed by this PR, or leave it open for the next 
minor or major release, as needed.
   
   >So if this regression is not reverted, I'd at least advocate for an API 
which would make the above statement correct. The current behavior silently 
adds COPY_ATTRIBUTES, which removes the ability to control this flag.
   
   That sounds like a compromise. Probably one of the two would then have to be 
marked as deprecated. I don't have a large-enough Java code base that I am 
maintaining a the moment to measure the impact, so take my comments with a 
pinch of salt :slightly_smiling_face: No hard feelings if other options are 
chosen here :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to