[
https://issues.apache.org/jira/browse/CSV-304?focusedWorklogId=806497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-806497
]
ASF GitHub Bot logged work on CSV-304:
--------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/22 18:36
Start Date: 06/Sep/22 18:36
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #257:
URL: https://github.com/apache/commons-csv/pull/257#issuecomment-1238516193
#
[Codecov](https://codecov.io/gh/apache/commons-csv/pull/257?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#257](https://codecov.io/gh/apache/commons-csv/pull/257?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0414d1e) into
[master](https://codecov.io/gh/apache/commons-csv/commit/c51b595e345954a286d59ed4e37d5d6d319cc78a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(c51b595) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #257 +/- ##
============================================
+ Coverage 96.99% 97.01% +0.02%
- Complexity 529 536 +7
============================================
Files 11 11
Lines 1166 1174 +8
Branches 204 205 +1
============================================
+ Hits 1131 1139 +8
Misses 23 23
Partials 12 12
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-csv/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...rc/main/java/org/apache/commons/csv/CSVParser.java](https://codecov.io/gh/apache/commons-csv/pull/257/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVlBhcnNlci5qYXZh)
| `95.67% <100.00%> (+0.22%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 806497)
Time Spent: 20m (was: 10m)
> Provide access methods for header and trailer comments
> ------------------------------------------------------
>
> Key: CSV-304
> URL: https://issues.apache.org/jira/browse/CSV-304
> Project: Commons CSV
> Issue Type: Improvement
> Components: Parser
> Affects Versions: 1.9.0
> Reporter: Peter Hull
> Priority: Minor
> Fix For: Discussion
>
> Attachments: header-comment.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Apache Commons CSV library can deal with comments by attaching the
> comment to the following record.
> It does not seem possible to access comments that are before the header line
> ("header comments"), or after the last record ("trailer comments")
> I feel this would be a useful enhancement to the current comment-handling
> features of version 1.9.
> I have not been able to find mention of this in other JIRA tickets.
> I have attached a patch implementing this, for discussion purposes. (n.b. I
> had trouble with git showing spurious ^M at the end of changed lines in
> CSVParserTest.java which I could not get rid of)
> This adds methods String CSVParser::getHeaderComment(), String
> CSVParser::getTrailerComment(), bool CSVParser::hasHeaderComment() and bool
> CSVParser::hasTrailerComment() . The last two could be omitted assuming a
> missing comment would return a null String.
>
> See also
> [https://stackoverflow.com/questions/72619095/get-leading-comments-from-csv-with-apache-commons-csv]
> and [https://lists.apache.org/thread/8tczpqlnjgbcyovyhb484tt11vqv91jt]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)