tisonkun commented on code in PR #904:
URL: https://github.com/apache/commons-lang/pull/904#discussion_r973510629
##########
src/test/java/org/apache/commons/lang3/ArchUtilsTest.java:
##########
@@ -113,6 +113,10 @@ public void testArchLabels() {
public void testGetProcessor() {
assertNotNull(ArchUtils.getProcessor(X86));
assertNull(ArchUtils.getProcessor("NA"));
+
+ final Processor processor = ArchUtils.getProcessor();
+ assertTrue(processor.isX86());
Review Comment:
This test will fail on machines with other arches (e.g. Apple M1 returns
`Processor.Type.AARCH_64`). I suggest we remove it.
cc @garydgregory @arturobernalg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
