garydgregory commented on code in PR #300:
URL: https://github.com/apache/commons-vfs/pull/300#discussion_r974081831
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java:
##########
@@ -148,6 +148,21 @@ public void freeUnusedResources() {
.forEach(AbstractFileSystem::closeCommunicationLink);
}
+ /**
+ * get snapshot of all fileSystem
+ *
+ * @return FileSystem Array
+ */
+ public AbstractFileSystem[] getAllFileSystemSnapshot() {
Review Comment:
Why not simply return a list.clone() which would also avoid the need to
manually create streams.
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java:
##########
@@ -148,6 +148,21 @@ public void freeUnusedResources() {
.forEach(AbstractFileSystem::closeCommunicationLink);
}
+ /**
+ * get snapshot of all fileSystem
Review Comment:
"get" -> "Gets"
##########
commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/AbstractFileProvider.java:
##########
@@ -148,6 +148,21 @@ public void freeUnusedResources() {
.forEach(AbstractFileSystem::closeCommunicationLink);
}
+ /**
+ * get snapshot of all fileSystem
+ *
+ * @return FileSystem Array
Review Comment:
New public APIs should have an '\@since' tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
