garydgregory commented on code in PR #146:
URL: https://github.com/apache/commons-bcel/pull/146#discussion_r974756058
##########
src/main/java/org/apache/bcel/classfile/ClassParser.java:
##########
@@ -59,7 +59,7 @@ public final class ClassParser {
/**
* Parses class from the given stream.
*
- * @param inputStream Input stream
+ * @param inputStream Input stream; the client should close it
Review Comment:
-1: No need to say this IMO, it should be a basic best practice that the
allocation site is the closing site. Only the opposite should be documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
