[
https://issues.apache.org/jira/browse/LANG-1692?focusedWorklogId=814957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-814957
]
ASF GitHub Bot logged work on LANG-1692:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/22 12:54
Start Date: 08/Oct/22 12:54
Worklog Time Spent: 10m
Work Description: tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r990638932
##########
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##########
@@ -110,8 +110,9 @@ private void appendFields(final Class<?> clazz) {
for (final Field field : FieldUtils.getAllFields(clazz)) {
if (accept(field)) {
try {
- diffBuilder.append(field.getName(), readField(field, left,
true),
- readField(field, right, true));
+ Object leftObject = readField(field, left, true);
Review Comment:
If you think it breaks the existing code and should not do it, you can
reject the PR. But I'm a bit confused since reverting it obviously causes
compile to fail.
Issue Time Tracking
-------------------
Worklog Id: (was: 814957)
Time Spent: 3h 40m (was: 3.5h)
> Cast FieldUtils.readField result to the recipient type
> ------------------------------------------------------
>
> Key: LANG-1692
> URL: https://issues.apache.org/jira/browse/LANG-1692
> Project: Commons Lang
> Issue Type: Task
> Components: lang.reflect.*
> Reporter: Zili Chen
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
