kinow commented on code in PR #965:
URL: https://github.com/apache/commons-lang/pull/965#discussion_r990698891
##########
src/main/java/org/apache/commons/lang3/time/DurationFormatUtils.java:
##########
@@ -190,9 +190,6 @@ public static String formatDurationWords(
duration = tmp;
tmp = StringUtils.replaceOnce(duration, " 0 minutes",
StringUtils.EMPTY);
duration = tmp;
- if (tmp.length() != duration.length()) {
- duration = StringUtils.replaceOnce(tmp, " 0 seconds",
StringUtils.EMPTY);
- }
Review Comment:
Or is it a bug? Maybe a copypasta bug where accidentally lines 190 and 192
were duplicated? Because there are `replaceOne` for "hour" and "minute", and
this block that was removed has the part for "seconds".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
