garydgregory commented on code in PR #969:
URL: https://github.com/apache/commons-lang/pull/969#discussion_r994918178
##########
src/main/java/org/apache/commons/lang3/StringUtils.java:
##########
@@ -3808,7 +3813,7 @@ public static boolean isNumericSpace(final CharSequence
cs) {
final int sz = cs.length();
for (int i = 0; i < sz; i++) {
final char nowChar = cs.charAt(i);
- if (nowChar != ' ' && !Character.isDigit(nowChar)) {
+ if (nowChar != PAD && !Character.isDigit(nowChar)) {
Review Comment:
The concept here is not "padding", it's "spacing", so it does not feel
appropriate to use the name "PAD". Note that we have a SPACE constant already
but it's a String, not a char, so maybe we need a private space char constant.
I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
