Claudenw commented on code in PR #335:
URL:
https://github.com/apache/commons-collections/pull/335#discussion_r997174291
##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractIndexProducerTest.java:
##########
@@ -93,6 +92,12 @@ int[] toArray() {
*/
protected abstract int getBehaviour();
+ protected abstract int[] getExpectedIndex();
+
+ protected int[] getExpectedForEach() {
+ return getExpectedIndex();
+ }
+
@Test
public final void testForEachIndex() {
Review Comment:
renamed
##########
src/test/java/org/apache/commons/collections4/bloomfilter/AbstractIndexProducerTest.java:
##########
@@ -144,12 +148,13 @@ public final void testBehaviourAsIndexArray() {
long count = Arrays.stream(actual).distinct().count();
Assertions.assertEquals(count, actual.length);
}
+ int[] expected = getExpectedIndex();
Review Comment:
moved to testAsIndexArray
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
