aherbert commented on PR #224: URL: https://github.com/apache/commons-math/pull/224#issuecomment-1287654895
I am -1 to changing `AccurateMath`. I made the change to the `KolmogorovSmirnovTest` in master. Thanks. I would not change the polynomial coefficients. From a maintenance perspective these are easier to maintain if the coefficients are raw. The extra + operation will be removed by the compiler at runtime. The other changes in `AccurateMath` are updating ` += -(xyz)` to ` -= (xyz)`. Alone this seems valid. However the sections are repeated throughout the code as a summation of terms. Keeping the ` += ` ensures it is clear that it is a summation and the term is readily identified. In some cases the same syntax is used a few line above to initialise the sum still within parentheses: `sum = -(x + y + z)`. The parentheses are also not required but when judged as a whole the code is more readable as a sum of composite terms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
